Support template secret #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kyungwan-nam , can you fix the gofmt and add unit test for function |
|
@zwwhdls |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 38.46% 38.64% +0.18%
==========================================
Files 33 33
Lines 3939 3959 +20
==========================================
+ Hits 1515 1530 +15
- Misses 2278 2283 +5
Partials 146 146
☔ View full report in Codecov by Sentry. |
|
@kyungwan-nam Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#698.
${pvc.name},${pvc.namespace},${pvc.annotations['<annotation>']}will be resolved by user's pvc.It works in my cluster.
can you review it when you are available?